feature/1766 - Add Show/Hide password to Submit Report Step #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddlees
requested changes
Mar 25, 2024
front-end/src/app/reports/submission-workflow/submit-report-step2.component.html
Show resolved
Hide resolved
|
toddlees
approved these changes
Mar 26, 2024
mjtravers
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a sonarcloud complaint about styling the eyeicon and eyeslashicon. This should be ok. All I did was move this from the debug-login.component.scss into the theme.css so that it would be available to both the debug-login page and the Submit Report page, as well as any future pages that make use of the show/hide password feature.